svn commit: samba r10346 - in branches/SAMBA_4_0/source/librpc/ndr: .

[metze at samba.org]

Author: metze
Date: 2005-09-20 11:39:40 +0000 (Tue, 20 Sep 2005)
New Revision: 10346

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=10346

Log:
here are only real ip-addresses valid, prevent dns lookups,
when the input is invalid

metze
Modified:
   branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c	2005-09-20 09:57:30 UTC (rev 10345)
+++ branches/SAMBA_4_0/source/librpc/ndr/ndr_basic.c	2005-09-20 11:39:40 UTC (rev 10346)
@@ -569,7 +569,9 @@
 */
 NTSTATUS ndr_push_ipv4address(struct ndr_push *ndr, int ndr_flags, const char *address)
 {
-	uint32_t addr = interpret_addr(address);
+	uint32_t addr;
+	if (!is_ipaddress(address)) return NT_STATUS_INVALID_PARAMETER_MIX;
+	addr = sys_inet_addr(address);
 	NDR_CHECK(ndr_push_uint32(ndr, ndr_flags, htonl(addr)));
 	return NT_STATUS_OK;
 }