svn commit: samba r9977 - in trunk/source/rpc_server: .

jra at samba.org jra at samba.org
Fri Sep 2 23:36:01 GMT 2005


Author: jra
Date: 2005-09-02 23:36:01 +0000 (Fri, 02 Sep 2005)
New Revision: 9977

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9977

Log:
Remove unused locals. Ensure we check prs out returns.
Jeremy.

Modified:
   trunk/source/rpc_server/srv_pipe.c


Changeset:
Modified: trunk/source/rpc_server/srv_pipe.c
===================================================================
--- trunk/source/rpc_server/srv_pipe.c	2005-09-02 23:25:59 UTC (rev 9976)
+++ trunk/source/rpc_server/srv_pipe.c	2005-09-02 23:36:01 UTC (rev 9977)
@@ -407,9 +407,7 @@
 		 */
 		char *data;
 		RPC_HDR_AUTH auth_info;
-
 		RPC_AUTH_SCHANNEL_CHK verf;
-		prs_struct rverf;
 
 		data = prs_data_p(&outgoing_pdu) + data_pos;
 		/* Check it's the type of reply we were expecting to decode */
@@ -426,15 +424,16 @@
 			return False;
 		}
 
-		prs_init(&rverf, 0, p->mem_ctx, MARSHALL);
-
 		schannel_encode(p->auth.a_u.schannel_auth, 
 			      p->auth.auth_level,
 			      SENDER_IS_ACCEPTOR,
 			      &verf, data, data_len + ss_padding_len);
 
-		smb_io_rpc_auth_schannel_chk("", RPC_AUTH_SCHANNEL_SIGN_OR_SEAL_CHK_LEN, 
-			&verf, &outgoing_pdu, 0);
+		if (!smb_io_rpc_auth_schannel_chk("", RPC_AUTH_SCHANNEL_SIGN_OR_SEAL_CHK_LEN, 
+				&verf, &outgoing_pdu, 0)) {
+			prs_mem_free(&outgoing_pdu);
+			return False;
+		}
 
 		p->auth.a_u.schannel_auth->seq_num++;
 	}



More information about the samba-cvs mailing list