svn commit: samba r9920 - in branches/SOC/SAMBA_4_0/source/libnet: .
brad at samba.org
brad at samba.org
Thu Sep 1 21:34:15 GMT 2005
Author: brad
Date: 2005-09-01 21:34:13 +0000 (Thu, 01 Sep 2005)
New Revision: 9920
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9920
Log:
Added disclaimer (I can't seem to get libnet_JoinDomain() to keep the samr_pipe and u_handle open past the function call, grrrr....).
Modified:
branches/SOC/SAMBA_4_0/source/libnet/libnet_join.c
Changeset:
Modified: branches/SOC/SAMBA_4_0/source/libnet/libnet_join.c
===================================================================
--- branches/SOC/SAMBA_4_0/source/libnet/libnet_join.c 2005-09-01 21:34:05 UTC (rev 9919)
+++ branches/SOC/SAMBA_4_0/source/libnet/libnet_join.c 2005-09-01 21:34:13 UTC (rev 9920)
@@ -426,6 +426,14 @@
return status;
}
}
+ /*
+ This code still has an issue in that it isn't storing the samr_pipe and the u_handle in mem_ctx,
+ and so they aren't staying open once this function returns.
+ Because of this, the RPC-NETLOGON torture test fails when trying to use the pipe and handle to leave
+ the domain.
+
+ Because they are local variables and not in a TALLOC_CTX, I can't talloc_steal() them.
+ */
r->out.join_password = talloc_steal(mem_ctx, password_str);
r->out.domain_sid = talloc_steal(mem_ctx, domain_sid);
r->out.domain_name = talloc_steal(mem_ctx, domain_name);
More information about the samba-cvs
mailing list