svn commit: samba r9889 - in trunk/source: include registry rpc_server

jerry at samba.org jerry at samba.org
Thu Sep 1 11:22:13 GMT 2005


Author: jerry
Date: 2005-09-01 11:22:13 +0000 (Thu, 01 Sep 2005)
New Revision: 9889

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9889

Log:
Pasted from mail to samba-technical after posting for review
(http://samba.org/~jerry/patches/eventlog_registry_r9822_v2.patch)

The main changes here are the move to regkey_open_internal()
which allows us to open a path and get REGISTRY_KEY*.  Which
can then be used in regkey_{fetch,store}_values().
Thus giving us a common API for storing configuration
information in the virtual registry.  Since this sits
on top of the REGISTRY_OPS* layer, it means the caller
doesn't have to worry about how or where the data is
actually stored.

The major problem with this patch is the control_eventlog_hook()
now requiring that you pass in an NT_USER_TOKEN* for the
access checks necessary in regkey_open_internal().  The
only place the control_eventlog_hook() code gets invoked is
in init_registry_data(), but this poses a problem since
we don't have a valid user token then.  But I could
just create a token for root (which would be similar
to opening a key under the context of LOCAL_SYSTEM
on Windows).







Modified:
   trunk/source/include/rpc_reg.h
   trunk/source/registry/reg_eventlog.c
   trunk/source/registry/reg_frontend.c
   trunk/source/registry/reg_printing.c
   trunk/source/registry/reg_util.c
   trunk/source/rpc_server/srv_eventlog_nt.c
   trunk/source/rpc_server/srv_reg_nt.c


Changeset:
Sorry, the patch is too large (1612 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9889


More information about the samba-cvs mailing list