svn commit: samba r11816 - in branches/SAMBA_4_0/source/librpc/rpc: .

tridge at samba.org tridge at samba.org
Mon Nov 21 02:52:34 GMT 2005


Author: tridge
Date: 2005-11-21 02:52:33 +0000 (Mon, 21 Nov 2005)
New Revision: 11816

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11816

Log:

this fixes some of the problems with the recent async rpc changes and
ncacn_ip_tcp/ncalrpc. The problem was that svn revision 11809 removed
the logic that forced the CONNECT auth type for authenticated binds
which don't have an explicit SIGN or SEAL flag set.

Modified:
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc_util.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc_util.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/rpc/dcerpc_util.c	2005-11-20 22:00:47 UTC (rev 11815)
+++ branches/SAMBA_4_0/source/librpc/rpc/dcerpc_util.c	2005-11-21 02:52:33 UTC (rev 11816)
@@ -975,6 +975,18 @@
 		 */
 
 		uint8_t auth_type;
+		
+		if ((p->conn->flags & (DCERPC_SIGN|DCERPC_SEAL)) == 0) {
+			/*
+			  we are doing an authenticated connection,
+			  but not using sign or seal. We must force
+			  the CONNECT dcerpc auth type as a NONE auth
+			  type doesn't allow authentication
+			  information to be passed.
+			*/
+			p->conn->flags |= DCERPC_CONNECT;
+		}
+
 		if (binding->flags & DCERPC_AUTH_SPNEGO) {
 			auth_type = DCERPC_AUTH_TYPE_SPNEGO;
 		} else if (binding->flags & DCERPC_AUTH_KRB5) {



More information about the samba-cvs mailing list