svn commit: samba r11455 - in trunk/source/rpcclient: .

jra at samba.org jra at samba.org
Wed Nov 2 00:37:51 GMT 2005


Author: jra
Date: 2005-11-02 00:37:49 +0000 (Wed, 02 Nov 2005)
New Revision: 11455

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11455

Log:
Last 2 uninitialized warnings.
Jeremy.

Modified:
   trunk/source/rpcclient/cmd_spoolss.c


Changeset:
Modified: trunk/source/rpcclient/cmd_spoolss.c
===================================================================
--- trunk/source/rpcclient/cmd_spoolss.c	2005-11-02 00:37:35 UTC (rev 11454)
+++ trunk/source/rpcclient/cmd_spoolss.c	2005-11-02 00:37:49 UTC (rev 11455)
@@ -1065,14 +1065,13 @@
                                          TALLOC_CTX *mem_ctx,
                                          int argc, const char **argv)
 {
-	WERROR werror;
+	WERROR werror = WERR_OK;
 	uint32          info_level = 1;
 	PRINTER_DRIVER_CTR 	ctr;
 	uint32		i, j,
 			returned;
 
-	if (argc > 2) 
-	{
+	if (argc > 2) {
 		printf("Usage: enumdrivers [level]\n");
 		return WERR_OK;
 	}
@@ -1082,8 +1081,7 @@
 
 
 	/* loop through and print driver info level for each architecture */
-	for (i=0; archi_table[i].long_archi!=NULL; i++) 
-	{
+	for (i=0; archi_table[i].long_archi!=NULL; i++) {
 		/* check to see if we already asked for this architecture string */
 
 		if ( i>0 && strequal(archi_table[i].long_archi, archi_table[i-1].long_archi) )
@@ -1115,22 +1113,22 @@
 			
 		case 1:
 			for (j=0; j < returned; j++) {
-				display_print_driver_1 (&(ctr.info1[j]));
+				display_print_driver_1 (&ctr.info1[j]);
 			}
 			break;
 		case 2:
 			for (j=0; j < returned; j++) {
-				display_print_driver_2 (&(ctr.info2[j]));
+				display_print_driver_2 (&ctr.info2[j]);
 			}
 			break;
 		case 3:
 			for (j=0; j < returned; j++) {
-				display_print_driver_3 (&(ctr.info3[j]));
+				display_print_driver_3 (&ctr.info3[j]);
 			}
 			break;
 		default:
 			printf("unknown info level %d\n", info_level);
-			break;
+			return WERR_UNKNOWN_LEVEL;
 		}
 	}
 	
@@ -1555,13 +1553,12 @@
                                          TALLOC_CTX *mem_ctx,
                                          int argc, const char **argv)
 {
-	WERROR result;
+	WERROR result = WERR_OK;
 	fstring			servername;
 	int			i;
 	
 	/* parse the command arguements */
-	if (argc != 2)
-	{
+	if (argc != 2) {
 		printf ("Usage: %s <driver>\n", argv[0]);
 		return WERR_OK;
         }
@@ -1570,8 +1567,7 @@
 	strupper_m(servername);
 
 	/* delete the driver for all architectures */
-	for (i=0; archi_table[i].long_archi; i++)
-	{
+	for (i=0; archi_table[i].long_archi; i++) {
 		/* make the call to remove the driver */
 		result = rpccli_spoolss_deleteprinterdriver(
 			cli, mem_ctx, archi_table[i].long_archi, argv[1]);
@@ -1582,9 +1578,7 @@
 					argv[1], archi_table[i].long_archi, 
 					W_ERROR_V(result));
 			}
-		} 
-		else 
-		{
+		} else {
 			printf ("Driver %s removed for arch [%s].\n", argv[1], 
 				archi_table[i].long_archi);
 		}



More information about the samba-cvs mailing list