svn commit: samba r7109 - in branches/SAMBA_4_0/source/build/pidl: .

jelmer at samba.org jelmer at samba.org
Mon May 30 13:48:35 GMT 2005


Author: jelmer
Date: 2005-05-30 13:48:35 +0000 (Mon, 30 May 2005)
New Revision: 7109

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7109

Log:
Change noid() to noopnum() so it isn't confusing to people familiar with id()

Modified:
   branches/SAMBA_4_0/source/build/pidl/ndr.pm
   branches/SAMBA_4_0/source/build/pidl/validator.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/pidl/ndr.pm
===================================================================
--- branches/SAMBA_4_0/source/build/pidl/ndr.pm	2005-05-30 12:57:59 UTC (rev 7108)
+++ branches/SAMBA_4_0/source/build/pidl/ndr.pm	2005-05-30 13:48:35 UTC (rev 7109)
@@ -452,7 +452,7 @@
 		$ndr->{PROPERTIES}->{pointer_default_top}
 	);
 
-	if (not defined($d->{PROPERTIES}{noid})) {
+	if (not defined($d->{PROPERTIES}{noopnum})) {
 		$thisopnum = ${$opnum};
 		${$opnum}++;
 	}

Modified: branches/SAMBA_4_0/source/build/pidl/validator.pm
===================================================================
--- branches/SAMBA_4_0/source/build/pidl/validator.pm	2005-05-30 12:57:59 UTC (rev 7108)
+++ branches/SAMBA_4_0/source/build/pidl/validator.pm	2005-05-30 13:48:35 UTC (rev 7109)
@@ -62,8 +62,7 @@
 	"idempotent"		=> {},
 
 	# function
-	"id"			=> {},# what is that? --metze 
-	"noid"			=> {},
+	"noopnum"		=> {},
 	"in"			=> {},
 	"out"			=> {},
 
@@ -259,14 +258,6 @@
 
 	ValidProperties($fn);
 
-	if (util::has_property($fn, "id")) {
-		nonfatal $fn, "[id()] is not correctly supported yet ($fn->{NAME})";
-	}
-
-	if (util::has_property($fn, "id") and util::has_property($fn, "noid")) {
-		fatal $fn, "function can't have [id()] and [noid] property ($fn->{NAME})";
-	}
-
 	foreach my $e (@{$fn->{ELEMENTS}}) {
 		$e->{PARENT} = $fn;
 		if (util::has_property($e, "ref") && !$e->{POINTERS}) {



More information about the samba-cvs mailing list