svn commit: samba r6866 - in trunk/source/nsswitch: .

[vlendec at samba.org]

Author: vlendec
Date: 2005-05-17 21:32:46 +0000 (Tue, 17 May 2005)
New Revision: 6866

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6866

Log:
A bit more cleanup work before the unixinfo pipe can be merged: sid2uid &
friends are not as cleanly separated into tiny async requests as
necessary. The real logic must happen in the parent. Convert sid2uid to that
logic, sid2gid and the reverse functions will follow.

This stuff becomes a bit hard to follow, but somehow the complexity is there
in a completely async coding style. This is a bit like spaghetti coding with
the continuation functions being goto targets.

Tridge, I think code-structure wise this is quite close to what samba4 winbind
might end up as. Maybe this is a lesson that a user-level co-routine library
can help in terms of code clarity? Try to follow winbindd_sid2uid_async
(winbindd_async.c:1159) and tell me where all that goes...

Volker

Modified:
   trunk/source/nsswitch/winbindd_async.c
   trunk/source/nsswitch/winbindd_dual.c
   trunk/source/nsswitch/winbindd_nss.h


Changeset:
Sorry, the patch is too large (497 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6866