svn commit: samba r6773 - in trunk/source/rpc_server: .

vlendec at samba.org vlendec at samba.org
Fri May 13 09:18:59 GMT 2005


Author: vlendec
Date: 2005-05-13 09:18:58 +0000 (Fri, 13 May 2005)
New Revision: 6773

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6773

Log:
Fix a valgrind error for samr_open_alias uncovered by one of John's test.

Jerry, in query_aliasmem, set_aliasinfo and set_groupinfo (and possibly
others) need become_root()/unbecome_root() around the pdb calls. I'm not sure
I would do the access checks correctly, I would much rather leave that to
you.

Volker
Modified:
   trunk/source/rpc_server/srv_samr_nt.c


Changeset:
Modified: trunk/source/rpc_server/srv_samr_nt.c
===================================================================
--- trunk/source/rpc_server/srv_samr_nt.c	2005-05-13 09:18:50 UTC (rev 6772)
+++ trunk/source/rpc_server/srv_samr_nt.c	2005-05-13 09:18:58 UTC (rev 6773)
@@ -2389,7 +2389,7 @@
 	make_samr_object_sd(p->mem_ctx, &psd, &sd_size, &ali_generic_mapping, NULL, 0);
 	se_map_generic(&des_access,&ali_generic_mapping);
 	
-	se_priv_add( &se_rights, &se_add_users );
+	se_priv_copy( &se_rights, &se_add_users );
 	
 	
 	status = access_check_samr_object(psd, p->pipe_user.nt_user_token, 



More information about the samba-cvs mailing list