svn commit: samba r6741 - in branches/SAMBA_4_0/source/lib/talloc: .

tridge at samba.org tridge at samba.org
Thu May 12 02:54:42 GMT 2005


Author: tridge
Date: 2005-05-12 02:54:42 +0000 (Thu, 12 May 2005)
New Revision: 6741

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6741

Log:
prevent talloc_strndup() from reading one byte past the end of a buffer, 
giving valgrind errors


Modified:
   branches/SAMBA_4_0/source/lib/talloc/talloc.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/talloc/talloc.c
===================================================================
--- branches/SAMBA_4_0/source/lib/talloc/talloc.c	2005-05-12 02:07:53 UTC (rev 6740)
+++ branches/SAMBA_4_0/source/lib/talloc/talloc.c	2005-05-12 02:54:42 UTC (rev 6741)
@@ -919,7 +919,7 @@
 	size_t len;
 	char *ret;
 
-	for (len=0; p[len] && len<n; len++) ;
+	for (len=0; len<n && p[len]; len++) ;
 
 	ret = _talloc(t, len + 1);
 	if (!ret) { return NULL; }



More information about the samba-cvs mailing list