svn commit: samba r6127 - in branches/SAMBA_3_0/source: include lib libads libsmb nsswitch rpc_server tdb utils

[derrell at samba.org]

"Gerald (Jerry) Carter" <jerry at samba.org> writes:

> derrell at samba.org wrote:
>
> | The flag -Wall should be added permanently to CFLAGS, and all warnings
> | then generated should be eliminated.
>
> Derrell,
>
> It is defined when you set --enable-developer

There's no reason that I can think of not to have -Wall in CFLAGS all the
time.  --enable-developer isn't obvious, and for those who don't know about
that (as I didn't and surely most of the non-team developers don't), errors
can be missed that the compiler could have caught.  I try to use -Wall in
everything I work on.  Compilers these days are just too good not to take
advantage of the bugs they can discover.

Derrell