svn commit: samba r6127 - in branches/SAMBA_3_0/source: include lib libads libsmb nsswitch rpc_server tdb utils

derrell at samba.org derrell at samba.org
Wed Mar 30 04:40:25 GMT 2005


Author: derrell
Date: 2005-03-30 04:40:24 +0000 (Wed, 30 Mar 2005)
New Revision: 6127

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6127

Log:
Eliminated all compiler warnings pertaining to mismatched "qualifiers".  The
whole of samba comiles warning-free with the default compiler flags.

Temporarily defined -Wall to locate other potential problems.  Found an 
unused static function (#ifdefed out rather than deleted, in case it's 
needed for something in progress).  

There are also a number of uses of undeclared functions, mostly krb5_*.  
Files with these problems need to have appropriate header files included, 
but they are not fixed in this update.

oplock_linux.c.c has undefined functions capget() and capset(), which need 
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>, 
but that could potentially have other side effects, so that remains uncorrected 
as well.
  
The flag -Wall should be added permanently to CFLAGS, and all warnings then 
generated should be eliminated.

Modified:
   branches/SAMBA_3_0/source/include/smb_macros.h
   branches/SAMBA_3_0/source/lib/smbldap.c
   branches/SAMBA_3_0/source/libads/kerberos.c
   branches/SAMBA_3_0/source/libsmb/spnego.c
   branches/SAMBA_3_0/source/nsswitch/winbindd_acct.c
   branches/SAMBA_3_0/source/nsswitch/winbindd_nss.h
   branches/SAMBA_3_0/source/nsswitch/winbindd_rpc.c
   branches/SAMBA_3_0/source/nsswitch/winbindd_util.c
   branches/SAMBA_3_0/source/rpc_server/srv_svcctl_nt.c
   branches/SAMBA_3_0/source/tdb/tdb.c
   branches/SAMBA_3_0/source/tdb/tdbutil.c
   branches/SAMBA_3_0/source/utils/net_ads.c
   branches/SAMBA_3_0/source/utils/net_lookup.c
   branches/SAMBA_3_0/source/utils/smbcontrol.c


Changeset:
Sorry, the patch is too large (258 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6127


More information about the samba-cvs mailing list