svn commit: samba r6078 - in branches/SAMBA_4_0/source/libcli/composite: .

[abartlet at samba.org]

Author: abartlet
Date: 2005-03-27 06:26:00 +0000 (Sun, 27 Mar 2005)
New Revision: 6078

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6078

Log:
Correctly fix the failures for NT1 (not SPNEGO) session setups in the
client.  The issue was actually a cut-and-paste bug, I was filling in
the .old not the .nt1 part of the union.

I've also removed the 'error checks' - I'll shortly document the API
for the credentials code to clarify that it will always return a
pointer here, except in cases of programmer error.

Tridge:  I hope this is OK.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/libcli/composite/sesssetup.c


Changeset:
Modified: branches/SAMBA_4_0/source/libcli/composite/sesssetup.c
===================================================================
--- branches/SAMBA_4_0/source/libcli/composite/sesssetup.c	2005-03-26 14:05:21 UTC (rev 6077)
+++ branches/SAMBA_4_0/source/libcli/composite/sesssetup.c	2005-03-27 06:26:00 UTC (rev 6078)
@@ -180,12 +180,8 @@
 	state->setup.nt1.in.os           = "Unix";
 	state->setup.nt1.in.lanman       = "Samba";
 	state->setup.nt1.in.user         = cli_credentials_get_username(io->in.credentials);
-	if (state->setup.nt1.in.user == NULL) return NULL;
 	state->setup.nt1.in.domain       = cli_credentials_get_domain(io->in.credentials);
-	if (state->setup.nt1.in.domain == NULL) return NULL;
 
-	state->setup.old.in.domain  = cli_credentials_get_domain(io->in.credentials);
-	state->setup.old.in.user    = cli_credentials_get_username(io->in.credentials);
 	if (!password) {
 		state->setup.nt1.in.password1 = data_blob(NULL, 0);
 		state->setup.nt1.in.password2 = data_blob(NULL, 0);