svn commit: samba r6000 - in branches/SAMBA_4_0/source: librpc/idl torture/rpc

[metze at samba.org]

Author: metze
Date: 2005-03-23 19:24:11 +0000 (Wed, 23 Mar 2005)
New Revision: 6000

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6000

Log:
add some notes about the cases where compression (or what ever this is)
is used, in the reply.

metze

Modified:
   branches/SAMBA_4_0/source/librpc/idl/drsuapi.idl
   branches/SAMBA_4_0/source/torture/rpc/drsuapi.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/idl/drsuapi.idl
===================================================================
--- branches/SAMBA_4_0/source/librpc/idl/drsuapi.idl	2005-03-23 18:55:12 UTC (rev 5999)
+++ branches/SAMBA_4_0/source/librpc/idl/drsuapi.idl	2005-03-23 19:24:11 UTC (rev 6000)
@@ -188,6 +188,11 @@
 	} drsuapi_DsReplicaCoursor05Ctr;
 
 	typedef [public] bitmap {
+		/* the _WRITEABLE flag seems to indicate a replication with all attributes,
+		 * and I'm currently always on error when it's set, but w2k and w2k3 uses it
+		 * in the dc join
+		 * --metze
+		 */
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_WRITEABLE				= 0x00000010,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_SYNC_ON_STARTUP			= 0x00000020,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_DO_SCHEDULED_SYNCS			= 0x00000040,
@@ -200,6 +205,15 @@
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_PREEMPTED				= 0x01000000,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_IGNORE_CHANGE_NOTIFICATIONS	= 0x04000000,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_DISABLE_SCHEDULED_SYNC		= 0x08000000,
+		/* 
+		 * the following NOTE applies to DsGetNCChangesRequest5:
+		 *  - the data is only compressed when 10 or more objects are replicated
+		 *  - but there could also be a size limit of 35 KBytes or something like that
+		 *  - the reply is DsGetNCChangesCtr2
+		 *  - maybe the same applies to DsGetNCChangesRequest8...
+		 *
+		 *  --metze
+		 */
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_COMPRESS_CHANGES			= 0x10000000,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_NO_CHANGE_NOTIFICATIONS		= 0x20000000,
 		DRSUAPI_DS_REPLICA_NEIGHBOUR_PARTIAL_ATTRIBUTE_SET		= 0x40000000

Modified: branches/SAMBA_4_0/source/torture/rpc/drsuapi.c
===================================================================
--- branches/SAMBA_4_0/source/torture/rpc/drsuapi.c	2005-03-23 18:55:12 UTC (rev 5999)
+++ branches/SAMBA_4_0/source/torture/rpc/drsuapi.c	2005-03-23 19:24:11 UTC (rev 6000)
@@ -923,7 +923,11 @@
 			r.in.req.req5.highwatermark.reserved_usn	= 0;
 			r.in.req.req5.highwatermark.highest_usn		= 0;
 			r.in.req.req5.uptodateness_vector		= NULL;
-			r.in.req.req5.replica_flags			= 0;
+			r.in.req.req5.replica_flags			= 0
+#if 0
+									| DRSUAPI_DS_REPLICA_NEIGHBOUR_COMPRESS_CHANGES
+#endif
+									;
 			r.in.req.req5.unknown2				= 0;
 			r.in.req.req5.unknown3				= 0;
 			r.in.req.req5.unknown4				= 0;