svn commit: samba r5972 - in trunk/source/libsmb: .

jra at samba.org jra at samba.org
Tue Mar 22 21:43:45 GMT 2005


Author: jra
Date: 2005-03-22 21:43:45 +0000 (Tue, 22 Mar 2005)
New Revision: 5972

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=5972

Log:
Fix up overwrite of last 2 bytes on clilist (could cause coredump).
Jeremy.

Modified:
   trunk/source/libsmb/clilist.c


Changeset:
Modified: trunk/source/libsmb/clilist.c
===================================================================
--- trunk/source/libsmb/clilist.c	2005-03-22 21:24:16 UTC (rev 5971)
+++ trunk/source/libsmb/clilist.c	2005-03-22 21:43:45 UTC (rev 5972)
@@ -281,14 +281,11 @@
 			dirlist = tdl;
 		}
 
-		/* put in a length for the last entry, to ensure we can chain entries 
-		   into the next packet */
+		/* we might need the lastname for continuations */
 		for (p2=p,i=0;i<ff_searchcount;i++) {
 			p2 += interpret_long_filename(cli,info_level,p2,&finfo);
 		}
-		SSVAL(p2,0,data_len - PTR_DIFF(p2,p));
 
-		/* we might need the lastname for continuations */
 		if (ff_lastname > 0) {
 			pstrcpy(mask, finfo.name);
 		} else {



More information about the samba-cvs mailing list