svn commit: samba r7955 - in branches/SAMBA_4_0/source/nbt_server/dgram: .

[metze at samba.org]

Author: metze
Date: 2005-06-27 19:32:52 +0000 (Mon, 27 Jun 2005)
New Revision: 7955

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7955

Log:
we should not free a struct which is passed as a parameter, to a function
the caller should free it

this fixed a double free bug noticed by  
?\208?\148?\208?\181?\208?\185?\209?\130?\208?\181?\209?\128 ?\208?\144?\208?\187?\208?\181?\208?\186?\209?\129?\208?\176?\208?\189?\208?\180?\209?\128 ?\208?\146?\208?\176?\208?\187?\208?\181?\209?\128?\208?\184?\208?\181?\208?\178?\208?\184?\209?\135 <tiamat at komi.mts.ru>?\194?\160

metze
Modified:
   branches/SAMBA_4_0/source/nbt_server/dgram/request.c


Changeset:
Modified: branches/SAMBA_4_0/source/nbt_server/dgram/request.c
===================================================================
--- branches/SAMBA_4_0/source/nbt_server/dgram/request.c	2005-06-27 18:53:38 UTC (rev 7954)
+++ branches/SAMBA_4_0/source/nbt_server/dgram/request.c	2005-06-27 19:32:52 UTC (rev 7955)
@@ -72,7 +72,6 @@
 	if (!NT_STATUS_IS_OK(status)) {
 		DEBUG(0,("Failed to bind to %s:%d - %s\n", 
 			 iface->bcast_address, lp_dgram_port(), nt_errstr(status)));
-		talloc_free(iface);
 		return status;
 	}
 	
@@ -87,7 +86,6 @@
 	if (!NT_STATUS_IS_OK(status)) {
 		DEBUG(0,("Failed to bind to %s:%d - %s\n", 
 			 bind_address, lp_dgram_port(), nt_errstr(status)));
-		talloc_free(iface);
 		return status;
 	}
 	dgram_set_incoming_handler(iface->dgmsock, dgram_request_handler, iface);