svn commit: samba r7865 - in branches/SAMBA_4_0/source: build/pidl libcli/nbt librpc/ndr librpc/rpc rpc_server rpc_server/echo rpc_server/remote

tridge at samba.org tridge at samba.org
Fri Jun 24 01:18:57 GMT 2005


Author: tridge
Date: 2005-06-24 01:18:56 +0000 (Fri, 24 Jun 2005)
New Revision: 7865

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7865

Log:
changed pidl to take a "const void *" instead of a "void *" for the
structure in ndr_push_*() and ndr_print_*(). The push and print
functions really should not modify the structure.

metze, to make this work I had to change your spoolss hand
marshaller. Can you please check it is OK? I think that the IN and OUT
sides of that function are not ever called on the same structure, so I
think that attempt at remembering the value by assigning to
r->in._offered was not doing anything anyway, but please correct me if
I have misunderstood it.

If you really do need to remember something on those structures I'd
suggest the ndr_token_store() and ndr_token_retrieve() functions,
which are used by pidl for just this sort of thing.

Modified:
   branches/SAMBA_4_0/source/build/pidl/dcom_stub.pm
   branches/SAMBA_4_0/source/build/pidl/ndr_header.pm
   branches/SAMBA_4_0/source/build/pidl/ndr_parser.pm
   branches/SAMBA_4_0/source/build/pidl/server.pm
   branches/SAMBA_4_0/source/libcli/nbt/nbtname.c
   branches/SAMBA_4_0/source/librpc/ndr/libndr.h
   branches/SAMBA_4_0/source/librpc/ndr/ndr.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_orpc.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_sec.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_sec_helper.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_spoolss_buf.c
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc.h
   branches/SAMBA_4_0/source/rpc_server/dcerpc_server.h
   branches/SAMBA_4_0/source/rpc_server/echo/rpc_echo.c
   branches/SAMBA_4_0/source/rpc_server/remote/dcesrv_remote.c


Changeset:
Sorry, the patch is too large (498 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7865


More information about the samba-cvs mailing list