svn commit: samba r7607 - branches/SAMBA_3_0/source/utils trunk/source/utils

gd at samba.org gd at samba.org
Wed Jun 15 13:01:20 GMT 2005


Author: gd
Date: 2005-06-15 13:01:19 +0000 (Wed, 15 Jun 2005)
New Revision: 7607

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=7607

Log:
Some minor fixes (typos, const)

Guenther

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc_printer.c
   trunk/source/utils/net_rpc_printer.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc_printer.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc_printer.c	2005-06-15 12:43:36 UTC (rev 7606)
+++ branches/SAMBA_3_0/source/utils/net_rpc_printer.c	2005-06-15 13:01:19 UTC (rev 7607)
@@ -296,7 +296,7 @@
 net_copy_fileattr(TALLOC_CTX *mem_ctx,
 		  struct cli_state *cli_share_src,
 		  struct cli_state *cli_share_dst, 
-		  char *src_name, char *dst_name,
+		  const char *src_name, const char *dst_name,
 		  BOOL copy_acls, BOOL copy_attrs,
 		  BOOL copy_timestamps, BOOL is_file)
 {
@@ -449,7 +449,7 @@
 NTSTATUS net_copy_file(TALLOC_CTX *mem_ctx,
 		       struct cli_state *cli_share_src,
 		       struct cli_state *cli_share_dst, 
-		       char *src_name, char *dst_name,
+		       const char *src_name, const char *dst_name,
 		       BOOL copy_acls, BOOL copy_attrs,
 		       BOOL copy_timestamps, BOOL is_file)
 {
@@ -1138,7 +1138,6 @@
 		 uint32 *num_printers, PRINTER_INFO_CTR *ctr)
 {
 
-	char *sharename;
 	POLICY_HND hnd;
 
 	/* no arguments given, enumerate all printers */
@@ -1154,9 +1153,7 @@
 
 
 	/* argument given, get a single printer by name */
-	sharename = SMB_STRDUP(argv[0]);
-
-	if (!net_spoolss_open_printer_ex(cli, mem_ctx, sharename,
+	if (!net_spoolss_open_printer_ex(cli, mem_ctx, argv[0],
 			MAXIMUM_ALLOWED_ACCESS,	cli->user_name, &hnd)) 
 		return False;
 
@@ -1255,7 +1252,7 @@
 
         for (i=0; archi_table[i].long_archi!=NULL; i++) {
 
-		int num_drivers;
+		uint32 num_drivers;
 
 		/* enum remote drivers */
 		if (!net_spoolss_enumprinterdrivers(cli, mem_ctx, level,
@@ -1396,7 +1393,7 @@
 }
 
 /** 
- * List print-queues w.r.t. thei publishing
+ * List print-queues w.r.t. their publishing state
  *
  * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passed through. 

Modified: trunk/source/utils/net_rpc_printer.c
===================================================================
--- trunk/source/utils/net_rpc_printer.c	2005-06-15 12:43:36 UTC (rev 7606)
+++ trunk/source/utils/net_rpc_printer.c	2005-06-15 13:01:19 UTC (rev 7607)
@@ -296,7 +296,7 @@
 net_copy_fileattr(TALLOC_CTX *mem_ctx,
 		  struct cli_state *cli_share_src,
 		  struct cli_state *cli_share_dst, 
-		  char *src_name, char *dst_name,
+		  const char *src_name, const char *dst_name,
 		  BOOL copy_acls, BOOL copy_attrs,
 		  BOOL copy_timestamps, BOOL is_file)
 {
@@ -449,7 +449,7 @@
 NTSTATUS net_copy_file(TALLOC_CTX *mem_ctx,
 		       struct cli_state *cli_share_src,
 		       struct cli_state *cli_share_dst, 
-		       char *src_name, char *dst_name,
+		       const char *src_name, const char *dst_name,
 		       BOOL copy_acls, BOOL copy_attrs,
 		       BOOL copy_timestamps, BOOL is_file)
 {
@@ -1137,7 +1137,6 @@
 		 uint32 *num_printers, PRINTER_INFO_CTR *ctr)
 {
 
-	char *sharename;
 	POLICY_HND hnd;
 
 	/* no arguments given, enumerate all printers */
@@ -1153,9 +1152,7 @@
 
 
 	/* argument given, get a single printer by name */
-	sharename = SMB_STRDUP(argv[0]);
-
-	if (!net_spoolss_open_printer_ex(cli, mem_ctx, sharename,
+	if (!net_spoolss_open_printer_ex(cli, mem_ctx, argv[0],
 			MAXIMUM_ALLOWED_ACCESS,	cli->user_name, &hnd)) 
 		return False;
 
@@ -1254,7 +1251,7 @@
 
         for (i=0; archi_table[i].long_archi!=NULL; i++) {
 
-		int num_drivers;
+		uint32 num_drivers;
 
 		/* enum remote drivers */
 		if (!net_spoolss_enumprinterdrivers(cli, mem_ctx, level,
@@ -1395,7 +1392,7 @@
 }
 
 /** 
- * List print-queues w.r.t. thei publishing
+ * List print-queues w.r.t. their publishing state
  *
  * All parameters are provided by the run_rpc_command function, except for
  * argc, argv which are passed through. 



More information about the samba-cvs mailing list