svn commit: samba r8857 - in branches/SAMBA_4_0/source/setup: .

tridge at samba.org tridge at samba.org
Sat Jul 30 02:02:53 GMT 2005


Author: tridge
Date: 2005-07-30 02:02:52 +0000 (Sat, 30 Jul 2005)
New Revision: 8857

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8857

Log:
please don't get fancy with embedded boolean statements in js
code. Especially as this is a new language for most Samba developers,
it is far better to err strongly on the side of readability rather
than trying to save a line of code by using fancy tricks

Modified:
   branches/SAMBA_4_0/source/setup/provision


Changeset:
Modified: branches/SAMBA_4_0/source/setup/provision
===================================================================
--- branches/SAMBA_4_0/source/setup/provision	2005-07-30 01:20:33 UTC (rev 8856)
+++ branches/SAMBA_4_0/source/setup/provision	2005-07-30 02:02:52 UTC (rev 8857)
@@ -106,8 +106,10 @@
 	subobj[key] = options[r];
 }
 
+var blank = (options["blank"] != undefined);
+
 message("Provisioning for %s in realm %s\n", subobj.DOMAIN, subobj.REALM);
 message("Using administrator password: %s\n", subobj.ADMINPASS);
-provision(subobj, message, options["blank"] != undefined);
+provision(subobj, message, blank);
 message("All OK\n");
 return 0;



More information about the samba-cvs mailing list