svn commit: samba r8786 - branches/SAMBA_3_0/source/utils trunk/source/utils

gd at samba.org gd at samba.org
Tue Jul 26 20:11:38 GMT 2005


Author: gd
Date: 2005-07-26 20:11:37 +0000 (Tue, 26 Jul 2005)
New Revision: 8786

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8786

Log:
Fix amazing and long-standing bug where user-accounts are just crippled
accounts (accounts without AcctCtrl set) after a vampire-process.

New Accounts tend to hace no acb_info at all which means "0"
(ACB_NORMAL). Unless 0 becomes not 0 we don't do anything and set *no*
acctrl for normal users at all (!). Those crippled users now don't show
up in usrmgr since 3.0.20somethings ldap-routines now finally test if
the attribute is there.

Guenther

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
   trunk/source/utils/net_rpc_samsync.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc_samsync.c	2005-07-26 18:48:36 UTC (rev 8785)
+++ branches/SAMBA_3_0/source/utils/net_rpc_samsync.c	2005-07-26 20:11:37 UTC (rev 8786)
@@ -482,8 +482,7 @@
 
 	/* TODO: account expiry time */
 
-	if (pdb_get_acct_ctrl(account) != delta->acb_info)
-		pdb_set_acct_ctrl(account, delta->acb_info, PDB_CHANGED);
+	pdb_set_acct_ctrl(account, delta->acb_info, PDB_CHANGED);
 
 	pdb_set_domain(account, lp_workgroup(), PDB_CHANGED);
 

Modified: trunk/source/utils/net_rpc_samsync.c
===================================================================
--- trunk/source/utils/net_rpc_samsync.c	2005-07-26 18:48:36 UTC (rev 8785)
+++ trunk/source/utils/net_rpc_samsync.c	2005-07-26 20:11:37 UTC (rev 8786)
@@ -482,8 +482,7 @@
 
 	/* TODO: account expiry time */
 
-	if (pdb_get_acct_ctrl(account) != delta->acb_info)
-		pdb_set_acct_ctrl(account, delta->acb_info, PDB_CHANGED);
+	pdb_set_acct_ctrl(account, delta->acb_info, PDB_CHANGED);
 
 	pdb_set_domain(account, lp_workgroup(), PDB_CHANGED);
 



More information about the samba-cvs mailing list