svn commit: samba r8624 - in branches/SAMBA_4_0/source/lib/tdb/common: .

tridge at samba.org tridge at samba.org
Wed Jul 20 00:09:24 GMT 2005


Author: tridge
Date: 2005-07-20 00:09:23 +0000 (Wed, 20 Jul 2005)
New Revision: 8624

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8624

Log:
removed valgrind comment on tdb that no longer applies









Modified:
   branches/SAMBA_4_0/source/lib/tdb/common/tdb.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/tdb/common/tdb.c
===================================================================
--- branches/SAMBA_4_0/source/lib/tdb/common/tdb.c	2005-07-19 23:53:48 UTC (rev 8623)
+++ branches/SAMBA_4_0/source/lib/tdb/common/tdb.c	2005-07-20 00:09:23 UTC (rev 8624)
@@ -27,25 +27,6 @@
 */
 
 
-/* NOTE: If you use tdbs under valgrind, and in particular if you run
- * tdbtorture, you may get spurious "uninitialized value" warnings.  I
- * think this is because valgrind doesn't understand that the mmap'd
- * area may be written to by other processes.  Memory can, from the
- * point of view of the grinded process, spontaneously become
- * initialized.
- *
- * I can think of a few solutions.  [mbp 20030311]
- *
- * 1 - Write suppressions for Valgrind so that it doesn't complain
- * about this.  Probably the most reasonable but people need to
- * remember to use them.
- *
- * 2 - Use IO not mmap when running under valgrind.  Not so nice.
- *
- * 3 - Use the special valgrind macros to mark memory as valid at the
- * right time.  Probably too hard -- the process just doesn't know.
- */ 
-
 #ifndef _SAMBA_BUILD_
 #if HAVE_CONFIG_H
 #include <config.h>



More information about the samba-cvs mailing list