svn commit: samba r8247 - in branches/SAMBA_4_0/source/libcli/nbt: .

[tridge at samba.org]

Author: tridge
Date: 2005-07-09 01:53:57 +0000 (Sat, 09 Jul 2005)
New Revision: 8247

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8247

Log:
remove the free of fullname in nbtname.c for now.

Metze, the ndr_token_store() code is storing temporary pointers into
this string in the token list, which means we are referring to freed
memory when we scan the token list. A better key might be a pointer
into the ndr buffer?

Modified:
   branches/SAMBA_4_0/source/libcli/nbt/nbtname.c


Changeset:
Modified: branches/SAMBA_4_0/source/libcli/nbt/nbtname.c
===================================================================
--- branches/SAMBA_4_0/source/libcli/nbt/nbtname.c	2005-07-09 01:53:45 UTC (rev 8246)
+++ branches/SAMBA_4_0/source/libcli/nbt/nbtname.c	2005-07-09 01:53:57 UTC (rev 8247)
@@ -343,8 +343,12 @@
 	}
 	
 	status = ndr_push_nbt_string(ndr, ndr_flags, fullname);
+#if 0
+	/* this free conflicts with the use of pointers into strings
+	   in the ndr_token_store() calls above. Metze, can you look
+	   at this? */
 	talloc_free(fullname);
-
+#endif
 	return status;
 }