svn commit: samba r8186 - in trunk/source: include lib passdb

[gd at samba.org]

Author: gd
Date: 2005-07-06 15:18:04 +0000 (Wed, 06 Jul 2005)
New Revision: 8186

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8186

Log:
fix some gcc4 warnings (signedness)

Guenther

Modified:
   trunk/source/include/passdb.h
   trunk/source/lib/account_pol.c
   trunk/source/lib/smbldap_util.c
   trunk/source/passdb/pdb_interface.c
   trunk/source/passdb/pdb_ldap.c


Changeset:
Modified: trunk/source/include/passdb.h
===================================================================
--- trunk/source/include/passdb.h	2005-07-06 14:56:45 UTC (rev 8185)
+++ trunk/source/include/passdb.h	2005-07-06 15:18:04 UTC (rev 8186)
@@ -375,10 +375,10 @@
 				    uint32 **attrs);
 
 	NTSTATUS (*pdb_get_account_policy)(struct pdb_context *context,
-					   int policy_index, int *value);
+					   int policy_index, uint32 *value);
 
 	NTSTATUS (*pdb_set_account_policy)(struct pdb_context *context,
-					   int policy_index, int value);
+					   int policy_index, uint32 value);
 
 	NTSTATUS (*pdb_get_seq_num)(struct pdb_context *context, time_t *seq_num);
 
@@ -497,10 +497,10 @@
 				uint32 **attrs);
 
 	NTSTATUS (*get_account_policy)(struct pdb_methods *methods,
-				       int policy_index, int *value);
+				       int policy_index, uint32 *value);
 
 	NTSTATUS (*set_account_policy)(struct pdb_methods *methods,
-				       int policy_index, int value);
+				       int policy_index, uint32 value);
 
 	NTSTATUS (*get_seq_num)(struct pdb_methods *methods, time_t *seq_num);
 

Modified: trunk/source/lib/account_pol.c
===================================================================
--- trunk/source/lib/account_pol.c	2005-07-06 14:56:45 UTC (rev 8185)
+++ trunk/source/lib/account_pol.c	2005-07-06 15:18:04 UTC (rev 8186)
@@ -240,7 +240,8 @@
 
 static BOOL migrate_account_policy_names_to_passdb(void)
 {
-	int i, tmp_val;
+	int i;
+	uint32 tmp_val;
 	BOOL got_pol;
 
 	if (already_migrated_account_policies(False)) {

Modified: trunk/source/lib/smbldap_util.c
===================================================================
--- trunk/source/lib/smbldap_util.c	2005-07-06 14:56:45 UTC (rev 8185)
+++ trunk/source/lib/smbldap_util.c	2005-07-06 15:18:04 UTC (rev 8186)
@@ -33,7 +33,8 @@
 						const char *domain_name)
 {
 	NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
-	int i, ldap_op, policy_default, rc;
+	int i, ldap_op, rc;
+	uint32 policy_default;
 	const char *policy_string = NULL;
 	const char *policy_comment = NULL;
 	pstring dn;

Modified: trunk/source/passdb/pdb_interface.c
===================================================================
--- trunk/source/passdb/pdb_interface.c	2005-07-06 14:56:45 UTC (rev 8185)
+++ trunk/source/passdb/pdb_interface.c	2005-07-06 15:18:04 UTC (rev 8186)
@@ -666,7 +666,7 @@
 }
 
 static NTSTATUS context_get_account_policy(struct pdb_context *context,
-					   int policy_index, int *value)
+					   int policy_index, uint32 *value)
 {
 	NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
 
@@ -680,7 +680,7 @@
 }
 
 static NTSTATUS context_set_account_policy(struct pdb_context *context,
-					   int policy_index, int value)
+					   int policy_index, uint32 value)
 {
 	NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
 
@@ -1363,7 +1363,7 @@
 					    num_rids, rids, names, attrs);
 }
 
-BOOL pdb_get_account_policy(int policy_index, int *value)
+BOOL pdb_get_account_policy(int policy_index, uint32 *value)
 {
 	struct pdb_context *pdb_context = pdb_get_static_context(False);
 
@@ -1375,7 +1375,7 @@
 			       pdb_get_account_policy(pdb_context, policy_index, value));
 }
 
-BOOL pdb_set_account_policy(int policy_index, int value)
+BOOL pdb_set_account_policy(int policy_index, uint32 value)
 {
 	struct pdb_context *pdb_context = pdb_get_static_context(False);
 
@@ -1460,12 +1460,12 @@
 	return; /* NT_STATUS_NOT_IMPLEMENTED; */
 }
 
-static NTSTATUS pdb_default_get_account_policy(struct pdb_methods *methods, int policy_index, int *value)
+static NTSTATUS pdb_default_get_account_policy(struct pdb_methods *methods, int policy_index, uint32 *value)
 {
 	return account_policy_get(policy_index, value) ? NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL;
 }
 
-static NTSTATUS pdb_default_set_account_policy(struct pdb_methods *methods, int policy_index, int value)
+static NTSTATUS pdb_default_set_account_policy(struct pdb_methods *methods, int policy_index, uint32 value)
 {
 	return account_policy_set(policy_index, value) ? NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL;
 }

Modified: trunk/source/passdb/pdb_ldap.c
===================================================================
--- trunk/source/passdb/pdb_ldap.c	2005-07-06 14:56:45 UTC (rev 8185)
+++ trunk/source/passdb/pdb_ldap.c	2005-07-06 15:18:04 UTC (rev 8186)
@@ -3273,7 +3273,7 @@
 	return NT_STATUS_OK;
 }
 
-static NTSTATUS ldapsam_get_account_policy(struct pdb_methods *methods, int policy_index, int *value)
+static NTSTATUS ldapsam_get_account_policy(struct pdb_methods *methods, int policy_index, uint32 *value)
 {
 	NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
 	LDAPMessage *result = NULL;
@@ -3283,7 +3283,7 @@
 	pstring filter;
 	char **vals;
 	const char *policy_string = NULL;
-	int tmp_val;
+	uint32 tmp_val;
 	BOOL found_tdb = False;
 
 	struct ldapsam_privates *ldap_state =
@@ -3387,7 +3387,7 @@
 	return ntstatus;
 }
 
-static NTSTATUS ldapsam_set_account_policy(struct pdb_methods *methods, int policy_index, int value)
+static NTSTATUS ldapsam_set_account_policy(struct pdb_methods *methods, int policy_index, uint32 value)
 {
 	NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
 	LDAPMessage *result = NULL;