svn commit: samba r8121 - in branches/SAMBA_4_0/source/torture: .

tridge at samba.org tridge at samba.org
Mon Jul 4 05:16:58 GMT 2005


Author: tridge
Date: 2005-07-04 05:16:57 +0000 (Mon, 04 Jul 2005)
New Revision: 8121

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8121

Log:
yuck. w2k3 seems to choose ERRDOS:ERRbaduid or
NT_STATUS_INVALID_HANDLE on a per call basis for a bad vuid. That
means it is doing checking for a valid vuid in each backend function,
rather than globally. I don't want to emulate that as it is way too
error prone, and could easily lead to a security hole, so instead
accept either error code in our test suite.

Modified:
   branches/SAMBA_4_0/source/torture/torture.c


Changeset:
Modified: branches/SAMBA_4_0/source/torture/torture.c
===================================================================
--- branches/SAMBA_4_0/source/torture/torture.c	2005-07-04 05:08:27 UTC (rev 8120)
+++ branches/SAMBA_4_0/source/torture/torture.c	2005-07-04 05:16:57 UTC (rev 8121)
@@ -1347,7 +1347,9 @@
 	}
 
 	if (!NT_STATUS_EQUAL(cli->transport->error.e.nt_status, 
-			     NT_STATUS_DOS(ERRSRV, ERRbaduid))) {
+			     NT_STATUS_DOS(ERRSRV, ERRbaduid)) &&
+	    !NT_STATUS_EQUAL(cli->transport->error.e.nt_status, 
+			     NT_STATUS_INVALID_HANDLE)) {
 		printf("ERROR: qfileinfo should have returned DOS error "
 		       "ERRSRV:ERRbaduid\n  but returned %s\n",
 		       smbcli_errstr(cli->tree));



More information about the samba-cvs mailing list