svn commit: samba r4902 - in branches/SAMBA_3_0/source/printing: .

jerry at samba.org jerry at samba.org
Fri Jan 21 18:14:31 GMT 2005


Author: jerry
Date: 2005-01-21 18:14:31 +0000 (Fri, 21 Jan 2005)
New Revision: 4902

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4902

Log:
please note that cupsDoRequest() deletes the request* so don't call ippDelete(request) *ever*
Modified:
   branches/SAMBA_3_0/source/printing/print_cups.c


Changeset:
Modified: branches/SAMBA_3_0/source/printing/print_cups.c
===================================================================
--- branches/SAMBA_3_0/source/printing/print_cups.c	2005-01-21 13:39:33 UTC (rev 4901)
+++ branches/SAMBA_3_0/source/printing/print_cups.c	2005-01-21 18:14:31 UTC (rev 4902)
@@ -177,6 +177,8 @@
 	*    requested-attributes
 	*/
 
+	request = ippNew();
+
 	request->request.op.operation_id = CUPS_GET_CLASSES;
 	request->request.op.request_id   = 1;
 
@@ -246,10 +248,6 @@
 	ret = True;
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -342,10 +340,6 @@
 	}
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -438,10 +432,6 @@
 	}
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -534,10 +524,6 @@
 	}
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -668,10 +654,6 @@
 	/* else print_job_end will do it for us */
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -988,10 +970,6 @@
 	*q = queue;
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -1086,10 +1064,6 @@
 	}
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 
@@ -1184,10 +1158,6 @@
 	}
 
  out:
-
-	if (request)
-		ippDelete(request);
-
 	if (response)
 		ippDelete(response);
 



More information about the samba-cvs mailing list