svn commit: samba r4813 - in branches/SAMBA_4_0/source/build/smb_build: .

tridge at samba.org tridge at samba.org
Tue Jan 18 03:27:13 GMT 2005


Author: tridge
Date: 2005-01-18 03:27:12 +0000 (Tue, 18 Jan 2005)
New Revision: 4813

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4813

Log:
this is a temporary solution to a link problem we have on some
platforms. The problem is that some loaders (for example the IRIX 6.5
machine us4 in the build farm) must have libs listed after object
files that depend on them on the link line. If you put the libs first
then all the symbols in the libs remain unresolved.

I think the correct fix for this is to separate xxx_LINK_LIBS out from
the current xxx_LINK_FLAGS, and use xxx_LINK_FLAGS followed by
xxx_LINK_LIST followed by xxx_LINK_LIBS. I'm hoping metze or jelmer,
as our build wizards, might take a look at this when they get time.

This interim fix should work fine, but its rather ugly, as it lists
the flags and libs twice in each link.

Modified:
   branches/SAMBA_4_0/source/build/smb_build/makefile.pm


Changeset:
Modified: branches/SAMBA_4_0/source/build/smb_build/makefile.pm
===================================================================
--- branches/SAMBA_4_0/source/build/smb_build/makefile.pm	2005-01-18 02:04:13 UTC (rev 4812)
+++ branches/SAMBA_4_0/source/build/smb_build/makefile.pm	2005-01-18 03:27:12 UTC (rev 4813)
@@ -487,7 +487,8 @@
 	\@echo Linking \$\@
 	\@\$(LD) \$(LD_FLAGS) -o \$\@ \\
 		\$(BINARY_$ctx->{NAME}_LINK_FLAGS) \\
-		\$(BINARY_$ctx->{NAME}_LINK_LIST)
+		\$(BINARY_$ctx->{NAME}_LINK_LIST) \\
+		\$(BINARY_$ctx->{NAME}_LINK_FLAGS)
 binary_$ctx->{BINARY}: basics bin/$ctx->{BINARY}
 # End Binary $ctx->{BINARY}
 ###################################



More information about the samba-cvs mailing list