svn commit: samba r4490 - in branches/SAMBA_4_0/source/rpc_server/samr: .

tridge at samba.org tridge at samba.org
Sun Jan 2 23:31:13 GMT 2005


Author: tridge
Date: 2005-01-02 23:31:12 +0000 (Sun, 02 Jan 2005)
New Revision: 4490

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=4490

Log:
when implementing one rpc server call in terms of another call, you
must zero r.out before making the 2nd call if the 2nd call has any
non-ref out parameters. This is needed for the case where the 2nd call
fails, and the 1st call would then fill in its out fields based on
uninitialised memory.






Modified:
   branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c


Changeset:
Modified: branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c
===================================================================
--- branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c	2005-01-02 23:25:25 UTC (rev 4489)
+++ branches/SAMBA_4_0/source/rpc_server/samr/dcesrv_samr.c	2005-01-02 23:31:12 UTC (rev 4490)
@@ -3306,6 +3306,7 @@
 	struct samr_QueryUserInfo r1;
 	NTSTATUS status;
 
+	ZERO_STRUCT(r1.out);
 	r1.in.user_handle = r->in.user_handle;
 	r1.in.level  = r->in.level;
 	
@@ -3321,7 +3322,7 @@
   samr_QueryDisplayInfo2 
 */
 static NTSTATUS samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-		       struct samr_QueryDisplayInfo2 *r)
+				       struct samr_QueryDisplayInfo2 *r)
 {
 	struct samr_QueryDisplayInfo q;
 	NTSTATUS result;
@@ -3331,6 +3332,7 @@
 	q.in.start_idx = r->in.start_idx;
 	q.in.max_entries = r->in.max_entries;
 	q.in.buf_size = r->in.buf_size;
+	ZERO_STRUCT(q.out);
 
 	result = samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
 



More information about the samba-cvs mailing list