svn commit: samba r5553 - in branches/SAMBA_4_0/source: librpc/idl torture/rpc

tpot at samba.org tpot at samba.org
Fri Feb 25 06:16:13 GMT 2005


Author: tpot
Date: 2005-02-25 06:16:13 +0000 (Fri, 25 Feb 2005)
New Revision: 5553

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=5553

Log:
Add idl and test for spoolss_AddPort().  It always seems to return
WERR_NOT_SUPPORTED though.

Modified:
   branches/SAMBA_4_0/source/librpc/idl/spoolss.idl
   branches/SAMBA_4_0/source/torture/rpc/spoolss.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/idl/spoolss.idl
===================================================================
--- branches/SAMBA_4_0/source/librpc/idl/spoolss.idl	2005-02-25 05:39:01 UTC (rev 5552)
+++ branches/SAMBA_4_0/source/librpc/idl/spoolss.idl	2005-02-25 06:16:13 UTC (rev 5553)
@@ -712,6 +712,9 @@
 	/******************/
 	/* Function: 0x25 */
 	WERROR spoolss_AddPort(
+	       [in] unistr *server_name,
+	       [in] uint32 unknown,
+	       [in] unistr monitor_name
 	);
 
 	/******************/

Modified: branches/SAMBA_4_0/source/torture/rpc/spoolss.c
===================================================================
--- branches/SAMBA_4_0/source/torture/rpc/spoolss.c	2005-02-25 05:39:01 UTC (rev 5552)
+++ branches/SAMBA_4_0/source/torture/rpc/spoolss.c	2005-02-25 06:16:13 UTC (rev 5553)
@@ -303,7 +303,7 @@
 	status = dcerpc_spoolss_EnumPorts(p, mem_ctx, &r);
 
 	if (!NT_STATUS_IS_OK(status)) {
-		printf("EnumPorts failed -- %s\n", nt_errstr(status));
+		printf("EnumPorts failed - %s\n", nt_errstr(status));
 		return False;
 	}
 
@@ -316,7 +316,7 @@
 		status = dcerpc_spoolss_EnumPorts(p, mem_ctx, &r);
 
 		if (!NT_STATUS_IS_OK(status)) {
-			printf("EnumPorts failed -- %s\n", nt_errstr(status));
+			printf("EnumPorts failed - %s\n", nt_errstr(status));
 			return False;
 		}
 
@@ -329,6 +329,39 @@
 	return True;
 }
 
+static BOOL test_AddPort(struct dcerpc_pipe *p, TALLOC_CTX *mem_ctx)
+{
+	NTSTATUS status;
+	struct spoolss_AddPort r;
+
+	r.in.server_name = talloc_asprintf(mem_ctx, "\\\\%s", 
+					   dcerpc_server_name(p));
+	r.in.unknown = 0;
+	r.in.monitor_name = "foo";
+
+	printf ("Testing AddPort\n");
+
+	status = dcerpc_spoolss_AddPort(p, mem_ctx, &r);
+
+	if (!NT_STATUS_IS_OK(status)) {
+		printf("AddPort failed - %s\n", nt_errstr(status));
+		return False;
+	}
+
+	/* win2k3 returns WERR_NOT_SUPPORTED */
+
+#if 0
+
+	if (!W_ERROR_IS_OK(r.out.result)) {
+		printf("AddPort failed - %s\n", win_errstr(r.out.result));
+		return False;
+	}
+
+#endif
+
+	return True;
+}
+
 static BOOL test_GetJob(struct dcerpc_pipe *p, TALLOC_CTX *mem_ctx,
 		  struct policy_handle *handle, uint32_t job_id)
 {
@@ -1095,6 +1128,8 @@
 
 	ret &= test_OpenPrinter_badnames(p, mem_ctx);
 
+	ret &= test_AddPort(p, mem_ctx);
+
 	ret &= test_EnumPorts(p, mem_ctx);
 
 	ret &= test_EnumPrinters(p, mem_ctx);



More information about the samba-cvs mailing list