svn commit: samba r12537 - in branches/SAMBA_4_0/source/nbt_server/dgram: .

tridge at samba.org tridge at samba.org
Wed Dec 28 08:20:48 GMT 2005


Author: tridge
Date: 2005-12-28 08:20:47 +0000 (Wed, 28 Dec 2005)
New Revision: 12537

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12537

Log:

finally found the difference between us and w2k3 that caused w2k
domain joins to be agonisingly slow! The join is now instant, and
login is fast too


Modified:
   branches/SAMBA_4_0/source/nbt_server/dgram/netlogon.c


Changeset:
Modified: branches/SAMBA_4_0/source/nbt_server/dgram/netlogon.c
===================================================================
--- branches/SAMBA_4_0/source/nbt_server/dgram/netlogon.c	2005-12-28 07:17:45 UTC (rev 12536)
+++ branches/SAMBA_4_0/source/nbt_server/dgram/netlogon.c	2005-12-28 08:20:47 UTC (rev 12537)
@@ -135,11 +135,18 @@
 
 	/* setup a GETDC reply */
 	ZERO_STRUCT(reply);
+	reply.command = NETLOGON_RESPONSE_FROM_PDC2;
+
+#if 0
+	/* newer testing shows that the reply command type is not
+	   changed based on whether a username is given in the
+	   reply. This was what was causing the w2k join to be so
+	   slow */
 	if (netlogon->req.pdc2.user_name[0]) {
 		reply.command = NETLOGON_RESPONSE_FROM_PDC_USER;
-	} else {
-		reply.command = NETLOGON_RESPONSE_FROM_PDC2;
 	}
+#endif
+
 	pdc = &reply.req.response2;
 
 	/* TODO: accurately depict which services we are running */



More information about the samba-cvs mailing list