svn commit: samba r12455 - in trunk/source/auth: .

vlendec at samba.org vlendec at samba.org
Fri Dec 23 19:21:05 GMT 2005


Author: vlendec
Date: 2005-12-23 19:21:05 +0000 (Fri, 23 Dec 2005)
New Revision: 12455

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12455

Log:
Micro-step: It's not add_user_group's job to free the server info on failure.

Volker


Modified:
   trunk/source/auth/auth_util.c


Changeset:
Modified: trunk/source/auth/auth_util.c
===================================================================
--- trunk/source/auth/auth_util.c	2005-12-23 18:02:26 UTC (rev 12454)
+++ trunk/source/auth/auth_util.c	2005-12-23 19:21:05 UTC (rev 12455)
@@ -858,7 +858,6 @@
 		
 	if (!NT_STATUS_IS_OK(status)) {
 		DEBUG(4,("get_user_groups_from_local_sam failed\n"));
-		free_server_info(server_info);
 		return status;
 	}
 	
@@ -873,7 +872,6 @@
 		DEBUG(4,("create_nt_user_token failed\n"));
 		SAFE_FREE(groupSIDs);
 		SAFE_FREE(unix_groups);
-		free_server_info(server_info);
 		return status;
 	}
 	
@@ -984,6 +982,7 @@
 				 sampass, pwd->pw_uid, pwd->pw_gid);
 
 	if (!NT_STATUS_IS_OK(status)) {
+		free_server_info(server_info);
 		return status;
 	}
 
@@ -1028,6 +1027,7 @@
 				 sampass, pwd->pw_uid, pwd->pw_gid);
 
 	if (!NT_STATUS_IS_OK(status)) {
+		free_server_info(server_info);
 		return status;
 	}
 



More information about the samba-cvs mailing list