svn commit: samba r12113 - in branches/SAMBA_4_0/source/smb_server/smb2: .

[metze at samba.org]

Author: metze
Date: 2005-12-07 07:14:13 +0000 (Wed, 07 Dec 2005)
New Revision: 12113

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12113

Log:
in SMB2 we should only allocate a new session
when the client sends UID = 0, otherwise we return
NT_STATUS_USER_SESSION_DELETED

metze
Modified:
   branches/SAMBA_4_0/source/smb_server/smb2/sesssetup.c


Changeset:
Modified: branches/SAMBA_4_0/source/smb_server/smb2/sesssetup.c
===================================================================
--- branches/SAMBA_4_0/source/smb_server/smb2/sesssetup.c	2005-12-06 23:42:50 UTC (rev 12112)
+++ branches/SAMBA_4_0/source/smb_server/smb2/sesssetup.c	2005-12-07 07:14:13 UTC (rev 12113)
@@ -29,7 +29,7 @@
 
 static NTSTATUS smb2srv_sesssetup_backend(struct smb2srv_request *req, struct smb2_session_setup *io)
 {
-	NTSTATUS status = NT_STATUS_ACCESS_DENIED;
+	NTSTATUS status;
 	struct smbsrv_session *smb_sess = NULL;
 	struct auth_session_info *session_info = NULL;
 	uint64_t vuid;
@@ -40,8 +40,8 @@
 
 	vuid = BVAL(req->in.hdr, SMB2_HDR_UID);
 
-	/* TODO: we're stricter than the SMB version till we have
-	 *       SMB2-CONTEXT test
+	/*
+	 * only when we got '0' we should allocate a new session
 	 */
 	if (vuid == 0) {
 		struct gensec_security *gensec_ctx;
@@ -67,10 +67,10 @@
 
 		/* allocate a new session */
 		smb_sess = smbsrv_session_new(req->smb_conn, gensec_ctx);
+		NT_STATUS_HAVE_NO_MEMORY(smb_sess);
 		status = smbsrv_smb2_init_tcons(smb_sess);
 		if (!NT_STATUS_IS_OK(status)) {
-			talloc_free(smb_sess);
-			smb_sess = NULL;
+			goto failed;
 		}
 	} else {
 		/* lookup an existing session */
@@ -78,7 +78,7 @@
 	}
 
 	if (!smb_sess) {
-		return NT_STATUS_ACCESS_DENIED;
+		return NT_STATUS_USER_SESSION_DELETED;
 	}
 
 	if (!smb_sess->gensec_ctx) {