svn commit: samba r12035 - in branches/SAMBA_4_0/source/kdc: .

abartlet at samba.org abartlet at samba.org
Fri Dec 2 22:37:08 GMT 2005


Author: abartlet
Date: 2005-12-02 22:37:07 +0000 (Fri, 02 Dec 2005)
New Revision: 12035

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=12035

Log:
Fix memory leaks in the KDC.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/kdc/hdb-ldb.c


Changeset:
Modified: branches/SAMBA_4_0/source/kdc/hdb-ldb.c
===================================================================
--- branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2005-12-02 21:56:12 UTC (rev 12034)
+++ branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2005-12-02 22:37:07 UTC (rev 12035)
@@ -704,6 +704,7 @@
 		nt_status = sam_get_results_principal((struct ldb_context *)db->hdb_db,
 						      mem_ctx, principal_string, 
 						      &msg, &realm_ref_msg);
+		free(principal_string);
 		if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
 			return HDB_ERR_NOENTRY;
 		} else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_MEMORY)) {
@@ -785,6 +786,7 @@
 						  mem_ctx, user_dn, &msg, krb5_attrs);
 			
 			if (ldb_ret != 1) {
+				talloc_free(mem_ctx);
 				return HDB_ERR_NOENTRY;
 			}
 			
@@ -793,6 +795,7 @@
 					       "ncName=%s", ldb_dn_linearize(mem_ctx, domain_dn));
 			
 			if (ldb_ret != 1) {
+				talloc_free(mem_ctx);
 				return HDB_ERR_NOENTRY;
 			}
 



More information about the samba-cvs mailing list