svn commit: samba r9584 - branches/SAMBA_3_0/source/smbd branches/SAMBA_4_0/source/torture branches/SAMBA_4_0/source/torture/raw trunk/source/smbd

[Jeremy Allison]

On Wed, Aug 24, 2005 at 01:15:02PM +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2005-08-24 13:15:01 +0000 (Wed, 24 Aug 2005)
> New Revision: 9584
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9584
> 
> Log:
> Fix a race condition in Samba 3. If two files are opened simultaneously with
> NTCREATEX_DISP_CREATE (create if not exists, else fail) they might end up with
> two or more times NT_STATUS_OK as EEXIST is not correctly handled.
> 
> Jeremy, please look closely at this. You can easily verify this by adding a
> smb_msleep(100) to the top of open_file_ntcreate and run the new samba4
> torture test. It does also happen without the msleep, but not as reliably.

Great catch - yes, that's been there for a while :-).

Jeremy.