svn commit: samba r9310 - in branches/SAMBA_4_0/source/kdc: .

[sfrench at samba.org]

Author: sfrench
Date: 2005-08-15 23:52:15 +0000 (Mon, 15 Aug 2005)
New Revision: 9310

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9310

Log:
Add two missing return statements after null pointer checks to fix potential oops in kdc code.
Found by coverity.

Modified:
   branches/SAMBA_4_0/source/kdc/hdb-ldb.c


Changeset:
Modified: branches/SAMBA_4_0/source/kdc/hdb-ldb.c
===================================================================
--- branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2005-08-15 23:15:59 UTC (rev 9309)
+++ branches/SAMBA_4_0/source/kdc/hdb-ldb.c	2005-08-15 23:52:15 UTC (rev 9310)
@@ -644,6 +644,7 @@
 	if (!spnmappings || spnmappings->num_values == 0) {
 		krb5_warnx(context, "ldb_search: dn: %s no sPNMappings attribute", service_dn);
 		krb5_set_error_string(context, "ldb_search: dn: %s no sPNMappings attribute", service_dn);
+		return HDB_ERR_NOENTRY;
 	}
 
 	for (i = 0; i < spnmappings->num_values; i++) {
@@ -664,6 +665,7 @@
 				   service_dn, mapping);
 			krb5_set_error_string(context, "ldb_search: dn: %s sPNMapping malformed: %s", 
 					      service_dn, mapping);
+			return HDB_ERR_NOENTRY;
 		}
 		p[0] = '\0';
 		p++;