svn commit: samba r9309 - in branches/SAMBA_4_0/source/libnet: .

sfrench at samba.org sfrench at samba.org
Mon Aug 15 23:15:59 GMT 2005


Author: sfrench
Date: 2005-08-15 23:15:59 +0000 (Mon, 15 Aug 2005)
New Revision: 9309

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=9309

Log:
Incorrect null pointer check in return from talloc.

Found by coverity.

Modified:
   branches/SAMBA_4_0/source/libnet/domain.c


Changeset:
Modified: branches/SAMBA_4_0/source/libnet/domain.c
===================================================================
--- branches/SAMBA_4_0/source/libnet/domain.c	2005-08-15 23:05:15 UTC (rev 9308)
+++ branches/SAMBA_4_0/source/libnet/domain.c	2005-08-15 23:15:59 UTC (rev 9309)
@@ -177,7 +177,7 @@
 	if (c == NULL) goto failure;
 
 	s = talloc_zero(c, struct domain_open_state);
-	if (c == NULL) goto failure;
+	if (s == NULL) goto failure;
 
 	c->state       = SMBCLI_REQUEST_SEND;
 	c->private     = s;



More information about the samba-cvs mailing list