svn commit: samba r8935 - branches/SAMBA_3_0/source/utils trunk/source/utils

tpot at samba.org tpot at samba.org
Tue Aug 2 19:15:20 GMT 2005


Author: tpot
Date: 2005-08-02 19:15:19 +0000 (Tue, 02 Aug 2005)
New Revision: 8935

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=8935

Log:
Fix signed/unsigned comparison warning.  Bugzilla #2943.

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc.c
   trunk/source/utils/net_rpc.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc.c	2005-08-02 18:56:18 UTC (rev 8934)
+++ branches/SAMBA_3_0/source/utils/net_rpc.c	2005-08-02 19:15:19 UTC (rev 8935)
@@ -4974,7 +4974,7 @@
 		return -1;
 	}
 
-	if (push_ucs2_talloc(mem_ctx, &uni_domain_name, domain_name_pol) < 0) {
+	if (push_ucs2_talloc(mem_ctx, &uni_domain_name, domain_name_pol) == (size_t)-1) {
 		DEBUG(0, ("Could not convert domain name %s to unicode\n",
 			  domain_name_pol));
 		return -1;
@@ -5128,7 +5128,7 @@
 		goto done;
 	}
 	
-	if (push_ucs2_talloc(mem_ctx, &uni_dom_name, trusted_dom_name) < 0) {
+	if (push_ucs2_talloc(mem_ctx, &uni_dom_name, trusted_dom_name) == (size_t)-1) {
 		DEBUG(0, ("Could not convert domain name %s to unicode\n",
 			  trusted_dom_name));
 		nt_status = NT_STATUS_UNSUCCESSFUL;

Modified: trunk/source/utils/net_rpc.c
===================================================================
--- trunk/source/utils/net_rpc.c	2005-08-02 18:56:18 UTC (rev 8934)
+++ trunk/source/utils/net_rpc.c	2005-08-02 19:15:19 UTC (rev 8935)
@@ -4974,7 +4974,7 @@
 		return -1;
 	}
 
-	if (push_ucs2_talloc(mem_ctx, &uni_domain_name, domain_name_pol) < 0) {
+	if (push_ucs2_talloc(mem_ctx, &uni_domain_name, domain_name_pol) == (size_t)-1) {
 		DEBUG(0, ("Could not convert domain name %s to unicode\n",
 			  domain_name_pol));
 		return -1;
@@ -5128,7 +5128,7 @@
 		goto done;
 	}
 	
-	if (push_ucs2_talloc(mem_ctx, &uni_dom_name, trusted_dom_name) < 0) {
+	if (push_ucs2_talloc(mem_ctx, &uni_dom_name, trusted_dom_name) == (size_t)-1) {
 		DEBUG(0, ("Could not convert domain name %s to unicode\n",
 			  trusted_dom_name));
 		nt_status = NT_STATUS_UNSUCCESSFUL;



More information about the samba-cvs mailing list