svn commit: samba r6182 - in
branches/SAMBA_4_0/source/librpc/ndr: .
Stefan (metze) Metzmacher
metze at samba.org
Mon Apr 4 05:53:18 GMT 2005
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
sharpe at samba.org schrieb:
| Author: sharpe
| Date: 2005-04-03 03:58:45 +0000 (Sun, 03 Apr 2005)
| New Revision: 6182
|
| WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6182
|
| Log:
|
| Jelmer, I think we need to initialize the switch_list, else we are
| crash city.
|
|
| Modified:
| branches/SAMBA_4_0/source/librpc/ndr/ndr.c
|
|
| Changeset:
| Modified: branches/SAMBA_4_0/source/librpc/ndr/ndr.c
| ===================================================================
| --- branches/SAMBA_4_0/source/librpc/ndr/ndr.c 2005-04-02 22:46:21 UTC (rev 6181)
| +++ branches/SAMBA_4_0/source/librpc/ndr/ndr.c 2005-04-03 03:58:45 UTC (rev 6182)
| @@ -320,7 +320,11 @@
| ndr->print = ndr_print_debug_helper;
| ndr->depth = 1;
| ndr->flags = 0;
| + ndr->switch_list = talloc(ndr, struct ndr_token_list);
| + if (!ndr->switch_list)
| + goto fail;
I can't see how this can fix the problem, when we initialize a pointer with another
uninitialized struct...
I have fixed it in rev 6188
- --
metze
Stefan Metzmacher <metze at samba.org> www.samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3-nr1 (Windows XP)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCUNZOm70gjA5TCD8RAkU8AJ9r5I7FfQFzBZnxbfWVvFUfjk5GKQCdG/cO
ZBdUoET0QudgKGpRpZdWmWg=
=P0EW
-----END PGP SIGNATURE-----
More information about the samba-cvs
mailing list