svn commit: samba r2481 - in branches/SAMBA_3_0/source/rpc_server: .

jra at samba.org jra at samba.org
Wed Sep 22 00:33:14 GMT 2004


Author: jra
Date: 2004-09-22 00:33:09 +0000 (Wed, 22 Sep 2004)
New Revision: 2481

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/rpc_server&rev=2481&nolog=1

Log:
Patch from Igor Belyi <sambauser at katehok.ac93.org>. Ensure pdb 
user is deleted first before deleting UNIX user (LDAP backend
needs this ordering).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2004-09-22 00:33:08 UTC (rev 2480)
+++ branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c	2004-09-22 00:33:09 UTC (rev 2481)
@@ -3675,7 +3675,14 @@
 		return NT_STATUS_NO_SUCH_USER;
 	}
 
-	/* delete the unix side */
+	/* First delete the samba side */
+	if (!pdb_delete_sam_account(sam_pass)) {
+		DEBUG(5,("_samr_delete_dom_user:Failed to delete entry for user %s.\n", pdb_get_username(sam_pass)));
+		pdb_free_sam(&sam_pass);
+		return NT_STATUS_CANNOT_DELETE;
+	}
+
+	/* Now delete the unix side */
 	/*
 	 * note: we don't check if the delete really happened
 	 * as the script is not necessary present
@@ -3683,13 +3690,7 @@
 	 */
 	smb_delete_user(pdb_get_username(sam_pass));
 
-	/* and delete the samba side */
-	if (!pdb_delete_sam_account(sam_pass)) {
-		DEBUG(5,("_samr_delete_dom_user:Failed to delete entry for user %s.\n", pdb_get_username(sam_pass)));
-		pdb_free_sam(&sam_pass);
-		return NT_STATUS_CANNOT_DELETE;
-	}
-	
+
 	pdb_free_sam(&sam_pass);
 
 	if (!close_policy_hnd(p, &q_u->user_pol))



More information about the samba-cvs mailing list