svn commit: samba r2466 - in branches/SAMBA_3_0/source/libsmb: .

vlendec at samba.org vlendec at samba.org
Tue Sep 21 07:55:49 GMT 2004


Author: vlendec
Date: 2004-09-21 07:55:49 +0000 (Tue, 21 Sep 2004)
New Revision: 2466

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/libsmb&rev=2466&nolog=1

Log:
Fix memleak found by sean.chandler at verizon.net.

Thanks!

Volker

Modified:
   branches/SAMBA_3_0/source/libsmb/cliconnect.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/cliconnect.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/cliconnect.c	2004-09-21 07:32:01 UTC (rev 2465)
+++ branches/SAMBA_3_0/source/libsmb/cliconnect.c	2004-09-21 07:55:49 UTC (rev 2466)
@@ -668,11 +668,16 @@
 		DATA_BLOB key = data_blob(ntlmssp_state->session_key.data,
 					  ntlmssp_state->session_key.length);
 		DATA_BLOB null_blob = data_blob(NULL, 0);
+		BOOL res;
 
 		fstrcpy(cli->server_domain, ntlmssp_state->server_domain);
 		cli_set_session_key(cli, ntlmssp_state->session_key);
 
-		if (cli_simple_set_signing(cli, key, null_blob)) {
+		res = cli_simple_set_signing(cli, key, null_blob);
+
+		data_blob_free(&key);
+
+		if (res) {
 			
 			/* 'resign' the last message, so we get the right sequence numbers
 			   for checking the first reply from the server */



More information about the samba-cvs mailing list