svn commit: samba r2242 - in branches/SAMBA_4_0/source/include: .

tridge at samba.org tridge at samba.org
Tue Sep 7 22:02:45 GMT 2004


Author: tridge
Date: 2004-09-07 22:02:44 +0000 (Tue, 07 Sep 2004)
New Revision: 2242

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source/include&rev=2242&nolog=1

Log:
some older versions of gcc don't properly handle the
PRINTF_ATTRIBUTE() format checking magic, so only enable it for gcc
versions >= 3.0


Modified:
   branches/SAMBA_4_0/source/include/includes.h


Changeset:
Modified: branches/SAMBA_4_0/source/include/includes.h
===================================================================
--- branches/SAMBA_4_0/source/include/includes.h	2004-09-07 16:42:09 UTC (rev 2241)
+++ branches/SAMBA_4_0/source/include/includes.h	2004-09-07 22:02:44 UTC (rev 2242)
@@ -53,10 +53,11 @@
 #define PRINTCAP_NAME "/etc/printcap"
 #endif
 
-#ifdef __GNUC__
+#if (__GNUC__ >= 3)
 /** Use gcc attribute to check printf fns.  a1 is the 1-based index of
  * the parameter containing the format, and a2 the index of the first
- * argument.  **/
+ * argument. Note that some gcc 2.x versions don't handle this
+ * properly **/
 #define PRINTF_ATTRIBUTE(a1, a2) __attribute__ ((format (__printf__, a1, a2)))
 #else
 #define PRINTF_ATTRIBUTE(a1, a2)



More information about the samba-cvs mailing list