svn commit: samba r3849 - in trunk/source/smbd: .

[vlendec at samba.org]

Author: vlendec
Date: 2004-11-18 15:14:17 +0000 (Thu, 18 Nov 2004)
New Revision: 3849

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=3849

Log:
Fix for bug 2057. Only partially applied the patch, the second part seems not
necessary.

I'm using gcc 3.4.1, this does not detect the possibly uninitialized
variable. Does anybody know how to get 3.4.1 to warn me?

Volker

Modified:
   trunk/source/smbd/lanman.c


Changeset:
Modified: trunk/source/smbd/lanman.c
===================================================================
--- trunk/source/smbd/lanman.c	2004-11-18 15:13:58 UTC (rev 3848)
+++ trunk/source/smbd/lanman.c	2004-11-18 15:14:17 UTC (rev 3849)
@@ -2145,6 +2145,12 @@
 		goto out;
 	}
 
+	snum = lp_servicenumber( sharename);
+	if (snum == -1) {
+		errcode = NERR_DestNotFound;
+		goto out;
+	}
+
 	errcode = NERR_notsupported;
 	
 	switch (function) {
@@ -2962,6 +2968,7 @@
   if(!rap_to_pjobid(SVAL(p,0),&snum,&jobid))
     return False;
 
+  snum = lp_servicenumber( sharename);
   if (snum < 0 || !VALID_SNUM(snum)) return(False);
 
   count = print_queue_status(snum,&queue,&status);