svn commit: samba r3763 - in trunk/source/utils: .

[jmcd at samba.org]

Author: jmcd
Date: 2004-11-15 17:32:02 +0000 (Mon, 15 Nov 2004)
New Revision: 3763

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=3763

Log:
Fix #1932: crash when non-root invokes net getlocalsid

First check to see if we can open secrets.tdb.

Modified:
   trunk/source/utils/net.c


Changeset:
Modified: trunk/source/utils/net.c
===================================================================
--- trunk/source/utils/net.c	2004-11-15 17:27:07 UTC (rev 3762)
+++ trunk/source/utils/net.c	2004-11-15 17:32:02 UTC (rev 3763)
@@ -495,11 +495,19 @@
 			  "backend knowlege (such as the sid stored in LDAP)\n"));
 	}
 
+	/* first check to see if we can even access secrets, so we don't
+	   panic when we can't. */
+
+	if (!secrets_init()) {
+		d_printf("Unable to open secrets.tdb.  Can't fetch domain SID for name: %s\n", name);
+		return 1;
+	}
+
 	/* Generate one, if it doesn't exist */
 	get_global_sam_sid();
 
 	if (!secrets_fetch_domain_sid(name, &sid)) {
-		DEBUG(0, ("Can't fetch domain SID for name: %s\n", name));	
+		DEBUG(0, ("Can't fetch domain SID for name: %s\n", name));
 		return 1;
 	}
 	sid_to_string(sid_str, &sid);