svn commit: samba r3756 - in branches/SAMBA_4_0/source/smb_server: .

vlendec at samba.org vlendec at samba.org
Mon Nov 15 12:24:02 GMT 2004


Author: vlendec
Date: 2004-11-15 12:24:02 +0000 (Mon, 15 Nov 2004)
New Revision: 3756

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=3756

Log:
Fix netbios session request reply. The buffer should not be a stack-based
variable that is overwritten later.

Samba3 smbclient still does not like Samba4. In ntlmssp samba3 smbclient
expects an mechlistmic that 4 does not send.

Volker

Modified:
   branches/SAMBA_4_0/source/smb_server/reply.c


Changeset:
Modified: branches/SAMBA_4_0/source/smb_server/reply.c
===================================================================
--- branches/SAMBA_4_0/source/smb_server/reply.c	2004-11-15 11:42:17 UTC (rev 3755)
+++ branches/SAMBA_4_0/source/smb_server/reply.c	2004-11-15 12:24:02 UTC (rev 3756)
@@ -2369,7 +2369,7 @@
 void reply_special(struct smbsrv_request *req)
 {
 	uint8_t msg_type;
-	char buf[4];
+	char *buf = talloc_zero_array_p(req, char, 4);
 	
 	msg_type = CVAL(req->in.buffer,0);
 



More information about the samba-cvs mailing list