svn commit: samba r3664 - in trunk/source/smbd: .

[jra at samba.org]

Author: jra
Date: 2004-11-10 19:34:59 +0000 (Wed, 10 Nov 2004)
New Revision: 3664

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=3664

Log:
Fix too tight checking of incoming secondary trans2 requests.
Found by Stefan Esser <s.esser at e-matters.de>.
Jeremy.

Modified:
   trunk/source/smbd/trans2.c


Changeset:
Modified: trunk/source/smbd/trans2.c
===================================================================
--- trunk/source/smbd/trans2.c	2004-11-10 19:34:50 UTC (rev 3663)
+++ trunk/source/smbd/trans2.c	2004-11-10 19:34:59 UTC (rev 3664)
@@ -4161,7 +4161,7 @@
 				goto bad_param;
 			
 			if (num_params) {
-				if (param_disp + num_params >= total_params)
+				if (param_disp + num_params > total_params)
 					goto bad_param;
 				if ((param_disp + num_params < param_disp) ||
 						(param_disp + num_params < num_params))
@@ -4177,7 +4177,7 @@
 				memcpy( &params[param_disp], smb_base(inbuf) + param_off, num_params);
 			}
 			if (num_data) {
-				if (data_disp + num_data >= total_data)
+				if (data_disp + num_data > total_data)
 					goto bad_param;
 				if ((data_disp + num_data < data_disp) ||
 						(data_disp + num_data < num_data))