svn commit: samba r3525 - in branches/SAMBA_3_0/source/libsmb: .

vlendec at samba.org vlendec at samba.org
Thu Nov 4 09:30:13 GMT 2004


Author: vlendec
Date: 2004-11-04 09:30:13 +0000 (Thu, 04 Nov 2004)
New Revision: 3525

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=3525

Log:
Fix a memleak

Volker

Modified:
   branches/SAMBA_3_0/source/libsmb/ntlm_check.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/ntlm_check.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/ntlm_check.c	2004-11-04 08:30:16 UTC (rev 3524)
+++ branches/SAMBA_3_0/source/libsmb/ntlm_check.c	2004-11-04 09:30:13 UTC (rev 3525)
@@ -93,6 +93,7 @@
 	uchar value_from_encryption[16];
 	uchar client_response[16];
 	DATA_BLOB client_key_data;
+	BOOL res;
 
 	if (part_passwd == NULL) {
 		DEBUG(10,("No password set - DISALLOWING access\n"));
@@ -146,7 +147,10 @@
 	dump_data(100, value_from_encryption, 16);
 #endif
 	data_blob_clear_free(&client_key_data);
-	return (memcmp(value_from_encryption, client_response, 16) == 0);
+	res = (memcmp(value_from_encryption, client_response, 16) == 0);
+	if ((!res) && (user_sess_key != NULL))
+		data_blob_clear_free(user_sess_key);
+	return res;
 }
 
 /**



More information about the samba-cvs mailing list