svn commit: samba r936 - branches/SAMBA_3_0/source/passdb

[Simo Sorce]

This seem related to a bug I recently had.
My problem this time was a misconfigured group mapping, but the effect
was that a NULL struct (I think) was passed back as members of the
administrators group.

I think we are getting wrong the way to return "we have zero members",
and windows picks up a NULL pointer and at this point all the bad
happens.

Unfortunately I was not able to determine exactly which was the right
way to address such issue (happens only on misconfigurations or
misbehaviours of the lookup functions).

Simo.

On Fri, 2004-05-28 at 10:57, abartlet at samba.org wrote:
> Author: abartlet
> Date: 2004-05-28 08:57:00 +0000 (Fri, 28 May 2004)
> New Revision: 936
> 
> Modified:
>    branches/SAMBA_3_0/source/passdb/lookup_sid.c
> Log:
> Fix a rather weird error that crippled my site, when we upgraded to
> Samba 3.0.4.
> 
> If we fail a query for the members of the 'administrators' group (and we may well just have the IDL wrong), this destroys later parts of the domain logon process. 
> 
> For reasons I can't understand, the client-side 'heck, what happened'
> bailout causes the connection to the DC to be dropped, and causes the
> mandetory profile not to be loaded.  (This also only occours after a reboot)
> 
> Return the members of 'administrators', and it all works fine.
> 
> The reason we hit this is because we run winbindd (to support
> pam_winbind) on our DC, and the winbindd lookup in sid_to_gid was
> messing things up.  As we don't care what type of thing this is,
> provided it exists in the group mapping db, we should not bother
> winbindd here.
> 
> Andrew Bartlett
> 
> 
> 
> WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/&rev=936&nolog=1
-- 
Simo Sorce    -  idra at samba.org
Samba Team    -  http://www.samba.org
Italian Site  -  http://samba.xsec.it