svn commit: samba r1269 - branches/SAMBA_4_0/source/librpc/ndr

tpot at samba.org tpot at samba.org
Sun Jun 27 12:01:03 GMT 2004


Author: tpot
Date: 2004-06-27 12:01:03 +0000 (Sun, 27 Jun 2004)
New Revision: 1269

Modified:
   branches/SAMBA_4_0/source/librpc/ndr/libndr.h
   branches/SAMBA_4_0/source/librpc/ndr/ndr.c
Log:
Add a 'base' field to the ndr_ofs_list structure which is the base to 
which the offset applies to.  In an array of structures containing
relative members, the offset applies to the start of the array element
being marshalled.  Previously, there was no way to access the relevant
structure start as by the time we have hit buffers, the head of the
offset list will be the last structure being marshalled.

Interestingly enough, this makes relstrs go away.  I think we thought
they were a special case in samba 3 but it turns out they are just 
regular relative elements in the idl.  This makes spoolss a lot simpler 
than I thought it would be.

I've run the samr and lsa tests and this doesn't seem to break anything.
It looks like security descriptors are the only structures that contain
relative members.

Oh yeah, this will probably require a 'make clean && make' otherwise you
will get bizzare errors.


WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/&rev=1269&nolog=1


More information about the samba-cvs mailing list