svn commit: samba r1203 - trunk/source/rpc_parse

vlendec at vlendec at
Sun Jun 20 08:37:14 GMT 2004

Author: vlendec
Date: 2004-06-20 08:37:14 +0000 (Sun, 20 Jun 2004)
New Revision: 1203

This hopefully fixes our memory use when unmarshalling strings. The test case
was 'rpcclient -c "enumprinters 2"' with 4000 printers. At some point this
completely exploded in memory usage. For every string we talloc'ed memory up
to the end of the buffer. -> O(n^2).

This survives valgrind with this number of printers. It might also have
influence on winbind with a large number of users.

All those who dare to look at samba3 rpc code, could you please take a look? I
know this is a burden, but I would like comments ;-)))



More information about the samba-cvs mailing list