CVS update: samba/source/utils
abartlet at samba.org
abartlet at samba.org
Wed Feb 25 22:09:46 GMT 2004
Date: Wed Feb 25 22:09:46 2004
Author: abartlet
Update of /data/cvs/samba/source/utils
In directory dp.samba.org:/tmp/cvs-serv25743/source/utils
Modified Files:
net.c smbpasswd.c
Log Message:
(merge from 3.0)
I *hate* global variables...
OK, what was happening here was that we would invalidate global_sam_sid
when we set the sid into secrets.tdb, to force a re-read.
The problem was, we would do *two* writes into the TDB, and the second one
(in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups
to fail, on a blank TDB.
By using a local variable in the pdb_generate_sam_sid() code, we avoid this
particular trap.
I've also added better debugging for the case where this all matters, which
is particularly for LDAP, where it finds out a domain SID from the sambaDomain
object.
Andrew Bartlett
Revisions:
net.c 1.91 => 1.92
http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/net.c.diff?r1=1.91&r2=1.92
smbpasswd.c 1.155 => 1.156
http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/smbpasswd.c.diff?r1=1.155&r2=1.156
More information about the samba-cvs
mailing list