CVS update: samba/source/lib

Jeremy Allison jra at samba.org
Mon Feb 2 18:33:39 GMT 2004


On Mon, Feb 02, 2004 at 12:02:44PM +0000, tridge at samba.org wrote:
> 
> I actually would greatly prefer to switch back to int for src_len. The
> type *can* be negative, which means an unsigned type is
> inappropriate. There is absolutely no reason why "int" should not be
> used for a parameter like this. 

Oh yes there is. src_len being -1 is a special case for a length
of a string - that should be the only permissable negative number.

A string length is not usually negative. The length being -1
is a one-off special case and should be treated as such.

Jeremy.


More information about the samba-cvs mailing list